lkml.org 
[lkml]   [2019]   [Nov]   [20]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
SubjectRe: [PATCH 2/2] mm/memory-failure.c: not necessary to recalculate hpage
From
Date
On 18.11.19 09:20, Wei Yang wrote:
> hpage is not changed.
>
> Signed-off-by: Wei Yang <richardw.yang@linux.intel.com>
> ---
> mm/memory-failure.c | 1 -
> 1 file changed, 1 deletion(-)
>
> diff --git a/mm/memory-failure.c b/mm/memory-failure.c
> index 392ac277b17d..9784f4339ae7 100644
> --- a/mm/memory-failure.c
> +++ b/mm/memory-failure.c
> @@ -1319,7 +1319,6 @@ int memory_failure(unsigned long pfn, int flags)
> }
> unlock_page(p);
> VM_BUG_ON_PAGE(!page_count(p), p);
> - hpage = compound_head(p);
> }
>
> /*
>

I am *absolutely* no transparent huge page expert (sorry :) ), but won't
the split_huge_page(p) eventually split the compound page, such that
compound_head(p) will return something else after that call?

--

Thanks,

David / dhildenb

\
 
 \ /
  Last update: 2019-11-20 16:08    [W:0.092 / U:1.596 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site