lkml.org 
[lkml]   [2019]   [Nov]   [20]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    Patch in this message
    /
    Date
    From
    Subject[tip: irq/core] irqchip: ingenic: Error out if IRQ domain creation failed
    The following commit has been merged into the irq/core branch of tip:

    Commit-ID: 52ecc87642f273a599c9913b29fd179c13de457b
    Gitweb: https://git.kernel.org/tip/52ecc87642f273a599c9913b29fd179c13de457b
    Author: Paul Cercueil <paul@crapouillou.net>
    AuthorDate: Wed, 02 Oct 2019 19:25:22 +08:00
    Committer: Marc Zyngier <maz@kernel.org>
    CommitterDate: Sun, 10 Nov 2019 18:55:30

    irqchip: ingenic: Error out if IRQ domain creation failed

    If we cannot create the IRQ domain, the driver should fail to probe
    instead of succeeding with just a warning message.

    Signed-off-by: Paul Cercueil <paul@crapouillou.net>
    Signed-off-by: Marc Zyngier <maz@kernel.org>
    Link: https://lore.kernel.org/r/1570015525-27018-3-git-send-email-zhouyanjie@zoho.com
    ---
    drivers/irqchip/irq-ingenic.c | 15 ++++++++++-----
    1 file changed, 10 insertions(+), 5 deletions(-)

    diff --git a/drivers/irqchip/irq-ingenic.c b/drivers/irqchip/irq-ingenic.c
    index 06fa810..d97a3a5 100644
    --- a/drivers/irqchip/irq-ingenic.c
    +++ b/drivers/irqchip/irq-ingenic.c
    @@ -87,6 +87,14 @@ static int __init ingenic_intc_of_init(struct device_node *node,
    goto out_unmap_irq;
    }

    + domain = irq_domain_add_legacy(node, num_chips * 32,
    + JZ4740_IRQ_BASE, 0,
    + &irq_domain_simple_ops, NULL);
    + if (!domain) {
    + err = -ENOMEM;
    + goto out_unmap_base;
    + }
    +
    for (i = 0; i < num_chips; i++) {
    /* Mask all irqs */
    writel(0xffffffff, intc->base + (i * CHIP_SIZE) +
    @@ -112,14 +120,11 @@ static int __init ingenic_intc_of_init(struct device_node *node,
    IRQ_NOPROBE | IRQ_LEVEL);
    }

    - domain = irq_domain_add_legacy(node, num_chips * 32, JZ4740_IRQ_BASE, 0,
    - &irq_domain_simple_ops, NULL);
    - if (!domain)
    - pr_warn("unable to register IRQ domain\n");
    -
    setup_irq(parent_irq, &intc_cascade_action);
    return 0;

    +out_unmap_base:
    + iounmap(intc->base);
    out_unmap_irq:
    irq_dispose_mapping(parent_irq);
    out_free:
    \
     
     \ /
      Last update: 2019-11-20 14:23    [W:4.169 / U:0.948 seconds]
    ©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site