Messages in this thread | | | Subject | Re: [PATCHv2 0/8] arm64: ftrace cleanup + FTRACE_WITH_REGS | From | Amit Daniel Kachhap <> | Date | Sat, 2 Nov 2019 17:42:25 +0530 |
| |
Hi Mark,
On 10/29/19 10:28 PM, Mark Rutland wrote: > Hi, > > This series is a reworked version of Torsten's FTRACE_WITH_REGS series > [1]. I've tried to rework the existing code in preparatory patches so > that the patchable-function-entry bits slot in with fewer surprises. > This version is based on v5.4-rc3, and can be found in my > arm64/ftrace-with-regs branch [2]. > > Patch 1 adds an (optional) ftrace_init_nop(), which the core code uses > to initialize callsites. This allows us to avoid a synthetic MCOUNT_ADDR > symbol, and more cleanly separates the one-time initialization of the > callsite from dynamic NOP<->CALL modification. Architectures which don't > implement this get the existing ftrace_make_nop() with MCOUNT_ADDR. > > Recently parisc gained ftrace support using patchable-function-entry. > Patch 2 makes the handling of module callsite locations common in > kernel/module.c with a new FTRACE_CALLSITE_SECTION definition, and > removed the newly redundant bits from arch/parisc. > > Patches 3 and 4 move the module PLT initialization to module load time, > which simplifies runtime callsite modification. This also means that we > don't transitently mark the module text RW, and will allow for the > removal of module_disable_ro(). > > Patches 5 and 6 add some trivial infrastructure, with patch 7 finally > adding FTRACE_WITH_REGS support. Additional work will be required for > livepatching (e.g. implementing reliable stack trace), which is > commented as part of patch 7. > > Patch 8 is a trivial cleanup atop of the rest of the series, making the > code easier to read and less susceptible to config-specific breakage. I tested the whole series with my latest in-kernel ptrauth patches [1] and graph_tracer/function_graph_tracer works fine, So for the whole series, Tested-by: Amit Daniel Kachhap <amit.kachhap@arm.com>
Also I gave few minor comments in the individual patches. With those comments, Signed-off-by: Amit Daniel Kachhap <amit.kachhap@arm.com>
Thanks, Amit Daniel [1]: https://patchwork.kernel.org/cover/11195085/ > > Since v1 [3]: > * Add a couple of people to Cc > * Fold in Ard's Reviewed-by tag > * Rename ftrace_code_init_disabled() to ftrace_nop_initialize() > * Move ftrace_init_nop() to <linux/ftrace.h>, with kerneldoc > * Update kerneldoc for rec parameters > > Thanks, > Mark. > > [1] https://lore.kernel.org/r/20190208150826.44EBC68DD2@newverein.lst.de > [2] git://git.kernel.org/pub/scm/linux/kernel/git/mark/linux.git arm64/ftrace-with-regs > [3] https://lore.kernel.org/r/20191021163426.9408-1-mark.rutland@arm.com > > Mark Rutland (7): > ftrace: add ftrace_init_nop() > module/ftrace: handle patchable-function-entry > arm64: module: rework special section handling > arm64: module/ftrace: intialize PLT at load time > arm64: insn: add encoder for MOV (register) > arm64: asm-offsets: add S_FP > arm64: ftrace: minimize ifdeffery > > Torsten Duwe (1): > arm64: implement ftrace with regs > > arch/arm64/Kconfig | 2 + > arch/arm64/Makefile | 5 ++ > arch/arm64/include/asm/ftrace.h | 23 +++++++ > arch/arm64/include/asm/insn.h | 3 + > arch/arm64/include/asm/module.h | 2 +- > arch/arm64/kernel/asm-offsets.c | 1 + > arch/arm64/kernel/entry-ftrace.S | 140 +++++++++++++++++++++++++++++++++++++-- > arch/arm64/kernel/ftrace.c | 123 ++++++++++++++++++++-------------- > arch/arm64/kernel/insn.c | 13 ++++ > arch/arm64/kernel/module-plts.c | 3 +- > arch/arm64/kernel/module.c | 57 +++++++++++++--- > arch/parisc/Makefile | 1 - > arch/parisc/kernel/module.c | 10 ++- > arch/parisc/kernel/module.lds | 7 -- > include/linux/ftrace.h | 40 ++++++++++- > kernel/module.c | 2 +- > kernel/trace/ftrace.c | 6 +- > 17 files changed, 355 insertions(+), 83 deletions(-) > delete mode 100644 arch/parisc/kernel/module.lds >
| |