Messages in this thread | | | Date | Fri, 15 Nov 2019 14:46:08 +0000 | From | Mark Rutland <> | Subject | Re: [PATCH v5 13/14] arm64: disable SCS for hypervisor code |
| |
On Tue, Nov 05, 2019 at 03:56:07PM -0800, Sami Tolvanen wrote: > Filter out CC_FLAGS_SCS for code that runs at a different exception > level. > > Suggested-by: Steven Rostedt (VMware) <rostedt@goodmis.org> > Signed-off-by: Sami Tolvanen <samitolvanen@google.com> > Reviewed-by: Kees Cook <keescook@chromium.org>
Looks sound, and objdump confirms that the hyp objects are using x29's frame record, without using x18.
Reviewed-by: Mark Rutland <mark.rutland@arm.com>
Mark.
> --- > arch/arm64/kvm/hyp/Makefile | 3 +++ > 1 file changed, 3 insertions(+) > > diff --git a/arch/arm64/kvm/hyp/Makefile b/arch/arm64/kvm/hyp/Makefile > index ea710f674cb6..17ea3da325e9 100644 > --- a/arch/arm64/kvm/hyp/Makefile > +++ b/arch/arm64/kvm/hyp/Makefile > @@ -28,3 +28,6 @@ GCOV_PROFILE := n > KASAN_SANITIZE := n > UBSAN_SANITIZE := n > KCOV_INSTRUMENT := n > + > +# remove the SCS flags from all objects in this directory > +KBUILD_CFLAGS := $(filter-out $(CC_FLAGS_SCS), $(KBUILD_CFLAGS)) > -- > 2.24.0.rc1.363.gb1bccd3e3d-goog >
| |