Messages in this thread | | | Date | Fri, 15 Nov 2019 14:06:36 +0800 | From | Herbert Xu <> | Subject | Re: [PATCH] crypto: hisilicon: no need to check return value of debugfs_create functions |
| |
On Thu, Nov 07, 2019 at 09:52:00AM +0100, Greg Kroah-Hartman wrote: > When calling debugfs functions, there is no need to ever check the > return value. The function can work or not, but the code logic should > never do something different based on this. > > Cc: Zhou Wang <wangzhou1@hisilicon.com> > Cc: Herbert Xu <herbert@gondor.apana.org.au> > Cc: "David S. Miller" <davem@davemloft.net> > Cc: linux-crypto@vger.kernel.org > Cc: linux-kernel@vger.kernel.org > Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org> > --- > drivers/crypto/hisilicon/qm.c | 19 +++++-------------- > drivers/crypto/hisilicon/zip/zip_main.c | 24 ++++++------------------ > 2 files changed, 11 insertions(+), 32 deletions(-)
Patch applied. Thanks. -- Email: Herbert Xu <herbert@gondor.apana.org.au> Home Page: http://gondor.apana.org.au/~herbert/ PGP Key: http://gondor.apana.org.au/~herbert/pubkey.txt
| |