Messages in this thread | | | From | Ian Rogers <> | Date | Fri, 15 Nov 2019 17:20:32 -0800 | Subject | Re: [PATCH v3 07/10] perf: simplify and rename visit_groups_merge |
| |
On Thu, Nov 14, 2019 at 2:03 AM Peter Zijlstra <peterz@infradead.org> wrote: > > On Wed, Nov 13, 2019 at 04:30:39PM -0800, Ian Rogers wrote: > > To enable a future caching optimization, pass in whether > > visit_groups_merge is operating on pinned or flexible groups. The > > is_pinned argument makes the func argument redundant, rename the > > function to ctx_groups_sched_in as it just schedules pinned or flexible > > groups in. Compute the cpu and groups arguments locally to reduce the > > argument list size. Remove sched_in_data as it repeats arguments already > > passed in. Remove the unused data argument to pinned_sched_in. > > Where did my first two patches go? Why aren't > {pinned,flexible}_sched_in() merged?
I've merged these 2 patches except for the helper function which is now trivial with the pinned boolean.
Thanks, Ian
| |