Messages in this thread | | | Subject | Re: [PATCH] irqchip/gic: Check interrupt type validity | From | Florian Fainelli <> | Date | Fri, 15 Nov 2019 14:32:48 -0800 |
| |
On 10/23/19 12:56 PM, Florian Fainelli wrote: > In case the interrupt property specifies a type parameter that is not > GIC_SPI (0) or GIC_PPIC (1), do not attempt to translate the interrupt > and return -EINVAL instead. > > Fixes: f833f57ff254 ("irqchip: Convert all alloc/xlate users from of_node to fwnode") > Signed-off-by: Florian Fainelli <f.fainelli@gmail.com> > --- > Marc, > > Regardless of whether my attempt to use SGI moves any further, this > seems appropriate to do since we should not be trying to translate > incorrectly specified interrupts. Thanks!
Ping?
> > drivers/irqchip/irq-gic.c | 3 +++ > 1 file changed, 3 insertions(+) > > diff --git a/drivers/irqchip/irq-gic.c b/drivers/irqchip/irq-gic.c > index 30ab623343d3..fc47e655618d 100644 > --- a/drivers/irqchip/irq-gic.c > +++ b/drivers/irqchip/irq-gic.c > @@ -1005,6 +1005,9 @@ static int gic_irq_domain_translate(struct irq_domain *d, > if (fwspec->param_count < 3) > return -EINVAL; > > + if (fwspec->param[0] > 1) > + return -EINVAL; > + > /* Get the interrupt number and add 16 to skip over SGIs */ > *hwirq = fwspec->param[1] + 16; > >
-- Florian
| |