lkml.org 
[lkml]   [2019]   [Nov]   [14]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    /
    From
    Date
    SubjectRe: [PATCH v4 32/47] serial: ucc_uart: use of_property_read_u32() in ucc_uart_probe()
    On Fri, Nov 8, 2019 at 7:03 AM Rasmus Villemoes
    <linux@rasmusvillemoes.dk> wrote:
    >
    > - if (*iprop)
    > - qe_port->port.uartclk = *iprop;
    > + if (val)
    > + qe_port->port.uartclk = val;
    > else {
    > /*
    > * Older versions of U-Boot do not initialize the brg-frequency
    > * property, so in this case we assume the BRG frequency is
    > * half the QE bus frequency.
    > */

    This bug in older U-Boots is definitely PowerPC-specific, so could you
    change this so that it reports an error on ARM if brg-frequency is
    zero, and displays a warning on PowerPC?

    \
     
     \ /
      Last update: 2019-11-14 14:58    [W:4.095 / U:0.708 seconds]
    ©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site