Messages in this thread | | | From | Arnd Bergmann <> | Date | Thu, 14 Nov 2019 11:52:38 +0100 | Subject | Re: [PATCH 21/23] y2038: itimer: change implementation to timespec64 |
| |
On Thu, Nov 14, 2019 at 3:06 AM Steven Rostedt <rostedt@goodmis.org> wrote: > On Wed, 13 Nov 2019 23:28:47 +0100 (CET) Thomas Gleixner <tglx@linutronix.de> wrote: > > > - __entry->value_usec = value->it_value.tv_usec; > > > + __entry->value_usec = value->it_value.tv_nsec / NSEC_PER_USEC; > > > __entry->interval_sec = value->it_interval.tv_sec; > > > - __entry->interval_usec = value->it_interval.tv_usec; > > > + __entry->interval_usec = value->it_interval.tv_nsec / NSEC_PER_USEC; > > > > Hmm, having a division in a tracepoint is clearly suboptimal. > > Right, we should move the division into the TP_printk() > > __entry->interval_nsec = alue->it_interval.tv_nsec; >
Ok, fixed now, thanks for the suggestion!
Arnd
| |