Messages in this thread | ![/](/images/icornerl.gif) | | Subject | Re: [PATCH 13/17] remoteproc/omap: add support for system suspend/resume | From | Tero Kristo <> | Date | Tue, 12 Nov 2019 10:45:18 +0200 |
| |
On 12/11/2019 08:15, Bjorn Andersson wrote: > On Mon 28 Oct 05:42 PDT 2019, Tero Kristo wrote: >> diff --git a/drivers/remoteproc/omap_remoteproc.c b/drivers/remoteproc/omap_remoteproc.c > [..] >> +static int _omap_rproc_suspend(struct rproc *rproc) > > I think it would make sense to inline this and _omap_rproc_resume() in > their single call sites.
Well, these get re-used in following patch for runtime PM also, so it is probably better leave this for compiler to decide?
> > [..] >> +static int _omap_rproc_resume(struct rproc *rproc) >> +{ > [..] >> @@ -806,6 +972,14 @@ static int omap_rproc_probe(struct platform_device *pdev) >> oproc->num_timers); >> } >> >> + init_completion(&oproc->pm_comp); >> + >> + oproc->fck = of_clk_get(np, 0); > > devm_clk_get() ? > > Otherwise I think you're lacking a clk_put() in omap_rproc_remove()
Yeah, let me replace with devm_clk_get.
-Tero
> > Regards, > Bjorn >
-- Texas Instruments Finland Oy, Porkkalankatu 22, 00180 Helsinki. Y-tunnus/Business ID: 0615521-4. Kotipaikka/Domicile: Helsinki
| ![\](/images/icornerr.gif) |