Messages in this thread | | | From | Avri Altman <> | Subject | RE: [PATCH v1 3/5] scsi: ufs: Update VCCQ2 and VCCQ min voltage hard codes | Date | Tue, 12 Nov 2019 07:56:20 +0000 |
| |
> > > Per UFS 3.0 JEDEC standard, the VCCQ2 min voltage is 1.7v and the VCCQ min > voltage is 1.14v, update their hard codes accordingly. > > Signed-off-by: Can Guo <cang@codeaurora.org> AFAIK, Vccq2 is 1.7 - 1.95 in UFS2.1 as well. Current constants applies to UFS1.1, as indicated in the original patch. Vccq is <1.1 - 1.3> in UFS2.1, and <1.14 - 1.26>, so need to update the max as well, and make the assignments in ufshcd_populate_vreg depends on hba->ufs_version?
> --- > drivers/scsi/ufs/ufs.h | 4 ++-- > 1 file changed, 2 insertions(+), 2 deletions(-) > > diff --git a/drivers/scsi/ufs/ufs.h b/drivers/scsi/ufs/ufs.h index 385bac8..9df4f4d > 100644 > --- a/drivers/scsi/ufs/ufs.h > +++ b/drivers/scsi/ufs/ufs.h > @@ -500,9 +500,9 @@ struct ufs_query_res { > #define UFS_VREG_VCC_MAX_UV 3600000 /* uV */ > #define UFS_VREG_VCC_1P8_MIN_UV 1700000 /* uV */ > #define UFS_VREG_VCC_1P8_MAX_UV 1950000 /* uV */ > -#define UFS_VREG_VCCQ_MIN_UV 1100000 /* uV */ > +#define UFS_VREG_VCCQ_MIN_UV 1140000 /* uV */ > #define UFS_VREG_VCCQ_MAX_UV 1300000 /* uV */ > -#define UFS_VREG_VCCQ2_MIN_UV 1650000 /* uV */ > +#define UFS_VREG_VCCQ2_MIN_UV 1700000 /* uV */ > #define UFS_VREG_VCCQ2_MAX_UV 1950000 /* uV */ > > /* > -- > The Qualcomm Innovation Center, Inc. is a member of the Code Aurora Forum, > a Linux Foundation Collaborative Project
| |