lkml.org 
[lkml]   [2019]   [Nov]   [11]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
SubjectRe: [PATCH -next] fsi: aspeed: Use devm_kfree in aspeed_master_release()
From
Date
On 11/8/19 7:32 PM, YueHaibing wrote:
> 'aspeed' is allocted by devm_kfree(), it should not be
> freed bt kfree().
>
> Fixes: 1edac1269c02 ("fsi: Add ast2600 master driver")
> Signed-off-by: YueHaibing <yuehaibing@huawei.com>
> ---
> drivers/fsi/fsi-master-aspeed.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/fsi/fsi-master-aspeed.c b/drivers/fsi/fsi-master-aspeed.c
> index 3dd82dd..0f63eec 100644
> --- a/drivers/fsi/fsi-master-aspeed.c
> +++ b/drivers/fsi/fsi-master-aspeed.c
> @@ -361,7 +361,7 @@ static void aspeed_master_release(struct device *dev)
> struct fsi_master_aspeed *aspeed =
> to_fsi_master_aspeed(dev_to_fsi_master(dev));
>
> - kfree(aspeed);
> + devm_kfree(dev, aspeed);
> }
>
> /* mmode encoders */
>
The memory is attached to the device, and will thus be freed once the device
is released. Why is the release function needed in the first place ?

Guenter

\
 
 \ /
  Last update: 2019-11-11 15:17    [W:1.572 / U:1.396 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site