Messages in this thread | | | Date | Mon, 11 Nov 2019 13:36:10 +0000 | From | Lee Jones <> | Subject | Re: [PATCH v3 02/11] mfd: wcd934x: add support to wcd9340/wcd9341 codec |
| |
> > > +static void wcd934x_slim_remove(struct slim_device *sdev) > > > +{ > > > + struct wcd934x_ddata *ddata = dev_get_drvdata(&sdev->dev); > > > + > > > + regulator_bulk_disable(WCD934X_MAX_SUPPLY, ddata->supplies); > > > + mfd_remove_devices(&sdev->dev); > > > + kfree(ddata); > > > +} > > > + > > > +static const struct slim_device_id wcd934x_slim_id[] = { > > > + { SLIM_MANF_ID_QCOM, SLIM_PROD_CODE_WCD9340, 0x1, 0x0 }, > > > > What do the last parameters mean? Might be better to define them. > > This is Instance ID and Device ID of SLIMBus enumeration address.
Great.
Please define them in the same was you did for the product code.
-- Lee Jones [李琼斯] Linaro Services Technical Lead Linaro.org │ Open source software for ARM SoCs Follow Linaro: Facebook | Twitter | Blog
| |