Messages in this thread | | | From | Arnd Bergmann <> | Date | Mon, 11 Nov 2019 20:18:12 +0100 | Subject | Re: [PATCH 8/8] Input: input_event: fix struct padding on sparc64 |
| |
On Mon, Nov 11, 2019 at 7:28 PM Dmitry Torokhov <dmitry.torokhov@gmail.com> wrote:
> I do not like ifdefs here, do you think we could write: > > client->buffer[client->tail] = (struct input_event) { > .input_event_sec = event->input_event_sec, > .input_event_usec = event->input_event_usec, > .type = EV_SYN, > .code = SYN_DROPPED, > }; > > to ensure all padded fields are initialized? This is not hot path as we > do not expect queue to overfill too often.
Good idea, changed both instances now. Thanks for taking a look!
Arnd
| |