| Date | Tue, 8 Oct 2019 14:20:01 +0200 | From | Pavel Machek <> | Subject | Re: [PATCH 4.19 018/106] clk: actions: Dont reference clk_init_data after registration |
| |
On Sun 2019-10-06 19:20:24, Greg Kroah-Hartman wrote: > From: Stephen Boyd <sboyd@kernel.org> > > [ Upstream commit cf9ec1fc6d7cceb73e7f1efd079d2eae173fdf57 ] > > A future patch is going to change semantics of clk_register() so that > clk_hw::init is guaranteed to be NULL after a clk is registered. Avoid > referencing this member here so that we don't run into NULL pointer > exceptions.
18,19,20,21: I see the patches make sense for mainline, but why were they selected for stable?
Pavel
> +++ b/drivers/clk/actions/owl-common.c > @@ -67,16 +67,17 @@ int owl_clk_probe(struct device *dev, struct clk_hw_onecell_data *hw_clks) > struct clk_hw *hw; > > for (i = 0; i < hw_clks->num; i++) { > + const char *name; > > hw = hw_clks->hws[i]; > - > if (IS_ERR_OR_NULL(hw)) > continue; > > + name = hw->init->name; > ret = devm_clk_hw_register(dev, hw); > if (ret) { > dev_err(dev, "Couldn't register clock %d - %s\n", > - i, hw->init->name); > + i, name); > return ret; > } > }
-- (english) http://www.livejournal.com/~pavelmachek (cesky, pictures) http://atrey.karlin.mff.cuni.cz/~pavel/picture/horses/blog.html [unhandled content-type:application/pgp-signature] |