Messages in this thread | | | From | Arnd Bergmann <> | Date | Tue, 8 Oct 2019 09:38:33 +0200 | Subject | Re: [PATCH v5 05/18] watchdog: cpwd: use generic compat_ptr_ioctl |
| |
On Tue, Oct 8, 2019 at 1:30 AM Guenter Roeck <linux@roeck-us.net> wrote: > > On Wed, Aug 14, 2019 at 10:42:32PM +0200, Arnd Bergmann wrote: > > The cpwd_compat_ioctl() contains a bogus mutex that dates > > back to a leftover BKL instance. > > > > Simplify the implementation by using the new compat_ptr_ioctl() > > helper function that will do the right thing for all calls > > here. > > > > Note that WIOCSTART/WIOCSTOP don't take any arguments, so > > the compat_ptr() conversion is not needed here, but it also > > doesn't hurt. > > > > Signed-off-by: Arnd Bergmann <arnd@arndb.de> > > Reviewed-by: Guenter Roeck <linux@roeck-us.net> > > This patch made it into the kernel, but the infrastructure didn't make it. > Do we need to revert it ?
Sorry I had not realized that this patch got queued in the watchdog tree and relied on the other patches. I ended up not sending the series after a runtime regression in another driver, combined with the series not having spent much time in linux-next before the merge window.
I've sent a fixup patch now that will make it do the right thing regardless of my series, please apply that for v5.4.
Arnd
| |