Messages in this thread | | | Date | Mon, 7 Oct 2019 18:02:53 +0100 | From | Mark Brown <> | Subject | Re: spi: Add call to spi_slave_abort() function when spidev driver is released |
| |
On Fri, Sep 27, 2019 at 12:38:49AM +0200, Lukasz Majewski wrote:
> Maybe, it would be sufficient for now to move the spi_slave_abort() in > spi_release() before we decrease (spidev->users--) the use count?
I think that should be OK, or possibly safer to do it at the start of the if (!spidev->users) section to avoid problems with fork()/exec() combinations. It'll need an if (spidev->spi) check as well, if we manage to hit that we've pretty much lost anyway though and I'm not sure I see a route to sensible error handling. [unhandled content-type:application/pgp-signature] | |