Messages in this thread | | | Date | Mon, 7 Oct 2019 11:08:04 -0400 | From | Steven Rostedt <> | Subject | Re: [RFC][PATCH 0/9] Variable size jump_label support |
| |
On Mon, 7 Oct 2019 14:55:19 +0200 Ingo Molnar <mingo@kernel.org> wrote:
> * Peter Zijlstra <peterz@infradead.org> wrote: > > > IIRC the recordmcount variant from Steve was also rewriting JMP8 to NOP2 > > at build time. > > > > I dug this here link out of my IRC logs: > > > > https://lore.kernel.org/lkml/1318007374.4729.58.camel@gandalf.stny.rr.com/ > > Ancient indeed ... > > > Looking at that, part of the reason might've been running yet another > > tool, instead of having one tool do everything. > > Yeah - that too wouldn't be a problem with objtool, as we are running it > anyway, right? > > So I can see about 2 valid technical reasons why Linus would have > objected to that old approach from Steve while finding the objtool > approach more acceptable. > > Basically the main assumption is that we better never run out of > competent objtool experts... :-)
Actually, even back then I said that it would be best to merge all the tools into one (I just didn't have the time to implement it), and then we could pull this off. I have one of my developers working to merge record-mcount into objtool now (there's been some patches floating around).
Then with a single tool, it shouldn't be controversial.
-- Steve
| |