Messages in this thread | | | Date | Fri, 4 Oct 2019 10:12:15 +0200 | From | Jan Kara <> | Subject | Re: [PATCH v2] quota: code cleanup for hash bits calculation |
| |
On Mon 23-09-19 21:52:23, Chengguang Xu wrote: > Code cleanup for hash bits calculation by > calling ilog2(). > > Signed-off-by: Chengguang Xu <cgxu519@zoho.com.cn>
Thanks! I've queued your patch.
Honza
> --- > v1->v2: > - Calculate hash bits by directly calling ilog2(). > > fs/quota/dquot.c | 6 +----- > 1 file changed, 1 insertion(+), 5 deletions(-) > > diff --git a/fs/quota/dquot.c b/fs/quota/dquot.c > index 6e826b454082..fde1b94ea587 100644 > --- a/fs/quota/dquot.c > +++ b/fs/quota/dquot.c > @@ -2983,11 +2983,7 @@ static int __init dquot_init(void) > > /* Find power-of-two hlist_heads which can fit into allocation */ > nr_hash = (1UL << order) * PAGE_SIZE / sizeof(struct hlist_head); > - dq_hash_bits = 0; > - do { > - dq_hash_bits++; > - } while (nr_hash >> dq_hash_bits); > - dq_hash_bits--; > + dq_hash_bits = ilog2(nr_hash); > > nr_hash = 1UL << dq_hash_bits; > dq_hash_mask = nr_hash - 1; > -- > 2.21.0 > > > > -- Jan Kara <jack@suse.com> SUSE Labs, CR
| |