Messages in this thread | | | From | Vincent Chen <> | Date | Tue, 8 Oct 2019 08:14:37 +0800 | Subject | Re: [PATCH 4/4] riscv: remove the switch statement in do_trap_break() |
| |
Sorry, I missed the comment. Christoph's suggestion is also good to me. I will modify it as you suggested. Thanks
On Tue, Oct 8, 2019 at 12:31 AM Paul Walmsley <paul.walmsley@sifive.com> wrote: > > On Mon, 7 Oct 2019, Christoph Hellwig wrote: > > > On Mon, Oct 07, 2019 at 09:08:23AM -0700, Paul Walmsley wrote: > > > force_sig_fault(SIGTRAP, TRAP_BRKPT, > > > (void __user *)(regs->sepc)); > > > > No nee for the extra braces, which also means it all fits onto a single > > line. > > Good point, will drop the extra parens and remove the braces. > > > - Paul
| |