Messages in this thread | | | From | Linus Walleij <> | Date | Fri, 4 Oct 2019 23:54:10 +0200 | Subject | Re: [PATCH v2] pinctrl: armada-37xx: fix control of pins 32 and up |
| |
On Tue, Oct 1, 2019 at 5:49 PM Patrick Williams <alpawi@amazon.com> wrote:
> The 37xx configuration registers are only 32 bits long, so > pins 32-35 spill over into the next register. The calculation > for the register address was done, but the bitmask was not, so > any configuration to pin 32 or above resulted in a bitmask that > overflowed and performed no action. > > Fix the register / offset calculation to also adjust the offset. > > Fixes: 5715092a458c ("pinctrl: armada-37xx: Add gpio support") > Signed-off-by: Patrick Williams <alpawi@amazon.com> > Acked-by: Gregory CLEMENT <gregory.clement@bootlin.com> > Cc: <stable@vger.kernel.org>
Patch applied for fixes.
Yours, Linus Walleij
| |