lkml.org 
[lkml]   [2019]   [Oct]   [4]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
From
SubjectRe: [PATCH V6 5/8] backlight: qcom-wled: Restructure the driver for WLED3
On 2019-10-01 20:47, Dan Murphy wrote:
> Kiran
>
> On 9/30/19 1:39 AM, Kiran Gunda wrote:
>> Restructure the driver to add the support for new WLED
>> peripherals.
>>
>> Signed-off-by: Kiran Gunda <kgunda@codeaurora.org>
>> Acked-by: Daniel Thompson <daniel.thompson@linaro.org>
>> ---
>> drivers/video/backlight/qcom-wled.c | 395
>> ++++++++++++++++++++++--------------
>> 1 file changed, 245 insertions(+), 150 deletions(-)
>>
>> diff --git a/drivers/video/backlight/qcom-wled.c
>> b/drivers/video/backlight/qcom-wled.c
>> index f191242..740f1b6 100644
>> --- a/drivers/video/backlight/qcom-wled.c
>> +++ b/drivers/video/backlight/qcom-wled.c
>> @@ -7,59 +7,71 @@
>> #include <linux/module.h>
>> #include <linux/of.h>
>> #include <linux/of_device.h>
>> +#include <linux/of_address.h>
>> #include <linux/regmap.h>
>> /* From DT binding */
>> +#define WLED_MAX_STRINGS 4
>> +
>> #define WLED_DEFAULT_BRIGHTNESS 2048
>> -#define WLED3_SINK_REG_BRIGHT_MAX 0xFFF
>> -#define WLED3_CTRL_REG_VAL_BASE 0x40
>> +#define WLED_SINK_REG_BRIGHT_MAX 0xFFF
>
> Why did you change some of these again?
>
> Can you just change it to the final #define in patch 4/8?
>
> Dan
>
> <snip>
Ok.. Looks like some thing went wrong with this series. I will re-upload
it again.

\
 
 \ /
  Last update: 2019-10-04 13:41    [W:0.046 / U:0.216 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site