| Date | Thu, 31 Oct 2019 20:56:31 -0700 | From | Kees Cook <> | Subject | Re: [PATCH v3 10/17] arm64: disable kretprobes with SCS |
| |
On Thu, Oct 31, 2019 at 09:46:30AM -0700, samitolvanen@google.com wrote: > With CONFIG_KRETPROBES, function return addresses are modified to > redirect control flow to kretprobe_trampoline. This is incompatible > with SCS. > > Signed-off-by: Sami Tolvanen <samitolvanen@google.com>
Reviewed-by: Kees Cook <keescook@chromium.org>
-Kees
> --- > arch/arm64/Kconfig | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/arch/arm64/Kconfig b/arch/arm64/Kconfig > index 3f047afb982c..e7b57a8a5531 100644 > --- a/arch/arm64/Kconfig > +++ b/arch/arm64/Kconfig > @@ -165,7 +165,7 @@ config ARM64 > select HAVE_STACKPROTECTOR > select HAVE_SYSCALL_TRACEPOINTS > select HAVE_KPROBES > - select HAVE_KRETPROBES > + select HAVE_KRETPROBES if !SHADOW_CALL_STACK > select HAVE_GENERIC_VDSO > select IOMMU_DMA if IOMMU_SUPPORT > select IRQ_DOMAIN > -- > 2.24.0.rc0.303.g954a862665-goog >
-- Kees Cook
|