Messages in this thread | | | Date | Thu, 31 Oct 2019 10:54:25 -0700 | From | Guenter Roeck <> | Subject | Re: [PATCH v2] nvme: Add hardware monitoring support |
| |
On Thu, Oct 31, 2019 at 02:45:49PM +0100, Christoph Hellwig wrote: > On Wed, Oct 30, 2019 at 07:20:37PM -0700, Guenter Roeck wrote: > >> The nvme_init_identify() can be called multiple time in nvme ctrl's > >> lifetime (e.g 'nvme reset /dev/nvme*' or suspend/resume paths), so > >> should we need to prevent nvme_hwmon_init() from registering hwmon > >> device more than twice? > >> > >> In the nvme thermal zone patchset[1], thernal zone is registered in > >> nvme_init_identify and unregistered in nvme_stop_ctrl(). > >> > > > > Doesn't that mean that the initialization should happen in nvme_start_ctrl() > > and not here ? > > I think calling it from nvme_init_identify is fine, it just needs to > be in the "if (!ctrl->identified)" section of that function.
Excellent, I'll do that. Thanks a lot for the hint!
Guenter
| |