lkml.org 
[lkml]   [2019]   [Oct]   [31]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
From
Date
SubjectRe: [RFC PATCH 04/10] pipe: Use head and tail pointers for the ring, not cursor and length [ver #2]
On Thu, Oct 31, 2019 at 4:11 PM David Howells <dhowells@redhat.com> wrote:
>
> How about:
>
> * We use head and tail indices that aren't masked off, except at the
> * point of dereference, but rather they're allowed to wrap naturally.
> * This means there isn't a dead spot in the buffer, provided the ring
> * size is a power of two and <= 2^31.

To me "provided" reads like this thing works without a dead spot or
with a dead spot, depending on whether the condition is met. I would
say:

> * This means there isn't a dead spot in the buffer, but the ring
> * size has to be a power of two and <= 2^31.

Thanks,

Ilya

\
 
 \ /
  Last update: 2019-10-31 16:59    [W:0.226 / U:0.668 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site