Messages in this thread | | | From | Ilya Dryomov <> | Date | Thu, 31 Oct 2019 16:57:53 +0100 | Subject | Re: [RFC PATCH 04/10] pipe: Use head and tail pointers for the ring, not cursor and length [ver #2] |
| |
On Thu, Oct 31, 2019 at 4:11 PM David Howells <dhowells@redhat.com> wrote: > > How about: > > * We use head and tail indices that aren't masked off, except at the > * point of dereference, but rather they're allowed to wrap naturally. > * This means there isn't a dead spot in the buffer, provided the ring > * size is a power of two and <= 2^31.
To me "provided" reads like this thing works without a dead spot or with a dead spot, depending on whether the condition is met. I would say:
> * This means there isn't a dead spot in the buffer, but the ring > * size has to be a power of two and <= 2^31.
Thanks,
Ilya
| |