Messages in this thread Patch in this message | | | Date | Thu, 31 Oct 2019 11:55:15 -0000 | From | "tip-bot2 for Jerry Snitselaar" <> | Subject | [tip: efi/urgent] efi/tpm: Return -EINVAL when determining tpm final events log size fails |
| |
The following commit has been merged into the efi/urgent branch of tip:
Commit-ID: 2bb6a81633cb47dcba4c9f75605cbe49e6b73d60 Gitweb: https://git.kernel.org/tip/2bb6a81633cb47dcba4c9f75605cbe49e6b73d60 Author: Jerry Snitselaar <jsnitsel@redhat.com> AuthorDate: Tue, 29 Oct 2019 18:37:51 +01:00 Committer: Ingo Molnar <mingo@kernel.org> CommitterDate: Thu, 31 Oct 2019 09:40:17 +01:00
efi/tpm: Return -EINVAL when determining tpm final events log size fails
Currently nothing checks the return value of efi_tpm_eventlog_init(), but in case that changes in the future make sure an error is returned when it fails to determine the tpm final events log size.
Suggested-by: Dan Carpenter <dan.carpenter@oracle.com> Signed-off-by: Jerry Snitselaar <jsnitsel@redhat.com> Signed-off-by: Ard Biesheuvel <ard.biesheuvel@linaro.org> Reviewed-by: Jarkko Sakkinen <jarkko.sakkinen@linux.intel.com> Cc: Linus Torvalds <torvalds@linux-foundation.org> Cc: Peter Zijlstra <peterz@infradead.org> Cc: Thomas Gleixner <tglx@linutronix.de> Cc: linux-efi@vger.kernel.org Fixes: e658c82be556 ("efi/tpm: Only set 'efi_tpm_final_log_size' after ...") Link: https://lkml.kernel.org/r/20191029173755.27149-3-ardb@kernel.org Signed-off-by: Ingo Molnar <mingo@kernel.org> --- drivers/firmware/efi/tpm.c | 1 + 1 file changed, 1 insertion(+)
diff --git a/drivers/firmware/efi/tpm.c b/drivers/firmware/efi/tpm.c index ebd7977..31f9f0e 100644 --- a/drivers/firmware/efi/tpm.c +++ b/drivers/firmware/efi/tpm.c @@ -88,6 +88,7 @@ int __init efi_tpm_eventlog_init(void) if (tbl_size < 0) { pr_err(FW_BUG "Failed to parse event in TPM Final Events Log\n"); + ret = -EINVAL; goto out_calc; }
| |