Messages in this thread | | | Subject | Re: [PATCH] tty: n_hdlc: fix build on SPARC | From | John Paul Adrian Glaubitz <> | Date | Wed, 30 Oct 2019 20:29:40 +0100 |
| |
On 10/30/19 7:34 PM, Kees Cook wrote: > On Mon, Sep 30, 2019 at 07:15:12PM -0700, Randy Dunlap wrote: >> From: Randy Dunlap <rdunlap@infradead.org> >> >> Fix tty driver build on SPARC by not using __exitdata. >> It appears that SPARC does not support section .exit.data. >> >> Fixes these build errors: >> >> `.exit.data' referenced in section `.exit.text' of drivers/tty/n_hdlc.o: defined in discarded section `.exit.data' of drivers/tty/n_hdlc.o >> `.exit.data' referenced in section `.exit.text' of drivers/tty/n_hdlc.o: defined in discarded section `.exit.data' of drivers/tty/n_hdlc.o >> `.exit.data' referenced in section `.exit.text' of drivers/tty/n_hdlc.o: defined in discarded section `.exit.data' of drivers/tty/n_hdlc.o >> `.exit.data' referenced in section `.exit.text' of drivers/tty/n_hdlc.o: defined in discarded section `.exit.data' of drivers/tty/n_hdlc.o >> >> Reported-by: kbuild test robot <lkp@intel.com> >> Fixes: 063246641d4a ("format-security: move static strings to const") >> Signed-off-by: Randy Dunlap <rdunlap@infradead.org> > > Wow. That commit is from 2.5 years ago. Is the SPARC port still alive? Yes, it is. No idea why we didn't run into this. I assume it affects certain configurations only. On Debian, we are always compiling and running the latest kernel versions on sparc64.
Adrian
-- .''`. John Paul Adrian Glaubitz : :' : Debian Developer - glaubitz@debian.org `. `' Freie Universitaet Berlin - glaubitz@physik.fu-berlin.de `- GPG: 62FF 8A75 84E0 2956 9546 0006 7426 3B37 F5B5 F913
| |