Messages in this thread | | | Subject | Re: [PATCH] thermal: brcmstb: enable hwmon | From | Florian Fainelli <> | Date | Wed, 30 Oct 2019 10:15:19 -0700 |
| |
On 10/30/19 9:57 AM, Florian Fainelli wrote: > Hi Chen-Yu, > > On 10/30/19 9:38 AM, Chen-Yu Tsai wrote: >> From: Chen-Yu Tsai <wens@csie.org> >> >> By defaul of-based thermal driver do not have hwmon entries registered. >> >> Do this explicitly so users can use standard hwmon interfaces and tools >> to read the temperature. >> >> This is based on similar changes for bcm2835_thermal in commit >> d56c19d07e0b ("thermal: bcm2835: enable hwmon explicitly"). >> >> Signed-off-by: Chen-Yu Tsai <wens@csie.org> > > Tested-by: Florian Fainelli <f.fainelli@gmail.com> > > There a number of patches that I need to get upstream from our > downstream tree, because right now the temperatures reported are note > quite in the expected units..
Oh yes, because we call the standard thermal framework helpers to extract the coefficients, and we never made that a mandatory property, so our firmware does not provide that information and the raw DAC code is not properly converted, will fix that as well. -- Florian
| |