lkml.org 
[lkml]   [2019]   [Oct]   [30]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
From
Date
SubjectRe: [PATCH v2] fault-inject: Use debugfs_create_ulong() instead of debugfs_create_ul()
2019年10月30日(水) 22:10 zhong jiang <zhongjiang@huawei.com>:
>
> debugfs_create_ulong() has implemented the function of debugfs_create_ul()
> in lib/fault-inject.c. hence we can replace it.
>
> Signed-off-by: zhong jiang <zhongjiang@huawei.com>
> ---
> lib/fault-inject.c | 43 ++++++++++++++-----------------------------
> 1 file changed, 14 insertions(+), 29 deletions(-)
>
> diff --git a/lib/fault-inject.c b/lib/fault-inject.c
> index 8186ca8..326fc1d 100644
> --- a/lib/fault-inject.c
> +++ b/lib/fault-inject.c
> @@ -151,10 +151,13 @@ bool should_fail(struct fault_attr *attr, ssize_t size)
> EXPORT_SYMBOL_GPL(should_fail);
>
> #ifdef CONFIG_FAULT_INJECTION_DEBUG_FS
> +#ifdef CONFIG_FAULT_INJECTION_STACKTRACE_FILTER
>
> -static int debugfs_ul_set(void *data, u64 val)
> +static int debugfs_stacktrace_depth_set(void *data, u64 val)
> {
> - *(unsigned long *)data = val;
> + *(unsigned long *)data =
> + min_t(unsigned long, val, MAX_STACK_TRACE_DEPTH);
> +
> return 0;
> }
>
> @@ -164,26 +167,8 @@ static int debugfs_ul_get(void *data, u64 *val)
> return 0;
> }
>
> -DEFINE_SIMPLE_ATTRIBUTE(fops_ul, debugfs_ul_get, debugfs_ul_set, "%llu\n");
> -
> -static void debugfs_create_ul(const char *name, umode_t mode,
> - struct dentry *parent, unsigned long *value)
> -{
> - debugfs_create_file(name, mode, parent, value, &fops_ul);
> -}
> -
> -#ifdef CONFIG_FAULT_INJECTION_STACKTRACE_FILTER
> -
> -static int debugfs_stacktrace_depth_set(void *data, u64 val)
> -{
> - *(unsigned long *)data =
> - min_t(unsigned long, val, MAX_STACK_TRACE_DEPTH);
> -
> - return 0;
> -}
> -
> -DEFINE_SIMPLE_ATTRIBUTE(fops_stacktrace_depth, debugfs_ul_get,
> - debugfs_stacktrace_depth_set, "%llu\n");
> +DEFINE_DEBUGFS_ATTRIBUTE(fops_stacktrace_depth, debugfs_ul_get,
> + debugfs_stacktrace_depth_set, "%llu\n");
>

The commit message doesn't describe the s/SIMPLE/DEBUGFS/ change
for fops_stacktrace_depth.

It is better to prepare another patch and I think debugfs_create_file()
in debugfs_create_stacktrace_depth() can now be replaced by
debugfs_create_file_unsafe().

\
 
 \ /
  Last update: 2019-10-30 14:40    [W:0.032 / U:0.148 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site