Messages in this thread | | | Date | Wed, 30 Oct 2019 20:09:53 +0800 | From | zhong jiang <> | Subject | Re: [PATCH] fault-inject: use DEFINE_DEBUGFS_ATTRIBUTE to define debugfs fops |
| |
On 2019/10/30 18:29, Akinobu Mita wrote: > 2019年10月30日(水) 17:26 zhong jiang <zhongjiang@huawei.com>: >> It is more clear to use DEFINE_DEBUGFS_ATTRIBUTE to define debugfs file >> operation rather than DEFINE_SIMPLE_ATTRIBUTE. >> >> Signed-off-by: zhong jiang <zhongjiang@huawei.com> >> --- >> lib/fault-inject.c | 4 ++-- >> 1 file changed, 2 insertions(+), 2 deletions(-) >> >> diff --git a/lib/fault-inject.c b/lib/fault-inject.c >> index 8186ca8..4e61326 100644 >> --- a/lib/fault-inject.c >> +++ b/lib/fault-inject.c >> @@ -164,7 +164,7 @@ static int debugfs_ul_get(void *data, u64 *val) >> return 0; >> } >> >> -DEFINE_SIMPLE_ATTRIBUTE(fops_ul, debugfs_ul_get, debugfs_ul_set, "%llu\n"); >> +DEFINE_DEBUGFS_ATTRIBUTE(fops_ul, debugfs_ul_get, debugfs_ul_set, "%llu\n"); >> >> static void debugfs_create_ul(const char *name, umode_t mode, >> struct dentry *parent, unsigned long *value) > Nowadays we have debugfs_create_ulong(), so should we use it instead of > debugfs_create_ul() defined in this file and remove the definision > altogether? > > . yes, you are right. That is better. I will repost in v2. Thanks
Sincerely, zhong jiang >
| |