lkml.org 
[lkml]   [2019]   [Oct]   [30]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
From
SubjectAntw: [PATCH v2] scsi: avoid potential deadloop in iscsi_if_rx func
>>> "wubo (T)" <wubo40@huawei.com> schrieb am 30.10.2019 um 08:56 in Nachricht
<EDBAAA0BBBA2AC4E9C8B6B81DEEE1D6915DFA0FE@dggeml505-mbs.china.huawei.com>:
> From: Bo Wu <wubo40@huawei.com>

...
> + if (--retries < 0) {
> + printk(KERN_ERR "Send reply failed too many times. "
> + "Max supported retries %u\n", ISCSI_SEND_MAX_ALLOWED);

Just for "personal taste": Why not simplify the message to:?
+ printk(KERN_ERR "Send reply failed too many times (%u)\n",
ISCSI_SEND_MAX_ALLOWED);

> + break;
> + }
> +

Maybe place the number after "many" as an alternative. I think as the message is expected to be rare, a short variant is justified.
Also one could discuss wether the problem that originates "from external" should be KERN_ERR, or maybe just a warning, because the kernel itself can do little against that problem, and it's not a "kernel error" after all ;-)

Regards,
Ulrich




\
 
 \ /
  Last update: 2019-10-30 09:16    [W:0.034 / U:0.876 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site