Messages in this thread | | | Date | Tue, 29 Oct 2019 14:38:36 +0100 (CET) | From | Julia Lawall <> | Subject | Re: Warning message from 'make nsdeps' when namespace is lower cases |
| |
On Tue, 29 Oct 2019, Masahiro Yamada wrote:
> Hi. > > When I was playing with 'make nsdeps', > I saw a new warning. > > If I rename USB_STORAGE to usb_storage, > I see 'warning: line 15: should usb_storage be a metavariable?' > Why? I think it comes from spatch.
Yes, it would come from spatch.
> It should be technically OK to use either upper or lower cases > for the namespace name.
What is normally wanted? Uppercase or lowercase?
julia
> > Just apply the following, and try 'make nsdeps'. > > > diff --git a/drivers/usb/storage/Makefile b/drivers/usb/storage/Makefile > index 46635fa4a340..6f817d65c26b 100644 > --- a/drivers/usb/storage/Makefile > +++ b/drivers/usb/storage/Makefile > @@ -8,7 +8,7 @@ > > ccflags-y := -I $(srctree)/drivers/scsi > > -ccflags-y += -DDEFAULT_SYMBOL_NAMESPACE=USB_STORAGE > +ccflags-y += -DDEFAULT_SYMBOL_NAMESPACE=usb_storage > > obj-$(CONFIG_USB_UAS) += uas.o > obj-$(CONFIG_USB_STORAGE) += usb-storage.o > > > > > > > > > > > -- > Best Regards > Masahiro Yamada >
| |