lkml.org 
[lkml]   [2019]   [Oct]   [29]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
SubjectRe: [PATCH] tools: PCI: Fix fd leakage
From
Date


On 26/10/19 7:05 AM, Hewenliang wrote:
> We should close fd before the return of run_test.
>
> Fixes: 3f2ed8134834 ("tools: PCI: Add a userspace tool to test PCI endpoint")
> Signed-off-by: Hewenliang <hewenliang4@huawei.com>

Acked-by: Kishon Vijay Abraham I <kishon@ti.com>
> ---
> tools/pci/pcitest.c | 1 +
> 1 file changed, 1 insertion(+)
>
> diff --git a/tools/pci/pcitest.c b/tools/pci/pcitest.c
> index cb1e51fcc84e..32b7c6f9043d 100644
> --- a/tools/pci/pcitest.c
> +++ b/tools/pci/pcitest.c
> @@ -129,6 +129,7 @@ static int run_test(struct pci_test *test)
> }
>
> fflush(stdout);
> + close(fd);
> return (ret < 0) ? ret : 1 - ret; /* return 0 if test succeeded */
> }
>
>

\
 
 \ /
  Last update: 2019-10-29 06:41    [W:0.035 / U:0.272 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site