lkml.org 
[lkml]   [2019]   [Oct]   [29]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
From
Date
SubjectRe: [PATCH RESEND 2/4] thermal: imx8mm: Add support for i.MX8MM thermal monitoring unit
Hi  Anson,

On Mon, Oct 28, 2019 at 3:07 AM Anson Huang <Anson.Huang@nxp.com> wrote:

> + ret = clk_prepare_enable(tmu->clk);
> + if (ret) {
> + dev_err(&pdev->dev, "failed to enable tmu clock: %d\n", ret);
> + return ret;
> + }
> +
> + tmu->tzd = devm_thermal_zone_of_sensor_register(&pdev->dev, 0,
> + tmu, &tmu_tz_ops);
> + if (IS_ERR(tmu->tzd)) {
> + dev_err(&pdev->dev,
> + "failed to register thermal zone sensor: %d\n", ret);

You should disable the tmu clock in the error path.

> + return PTR_ERR(tmu->tzd);

\
 
 \ /
  Last update: 2019-10-29 11:26    [W:0.039 / U:2.636 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site