lkml.org 
[lkml]   [2019]   [Oct]   [29]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
From
SubjectRe: [PATCH] b43: Fix use true/false for bool type
Hi Saurav,

thanks for your patch.

On Tue, Oct 29, 2019 at 12:32:04AM +0530, Saurav Girepunje wrote:
> use true/false on bool type variable assignment.
>
> Signed-off-by: Saurav Girepunje <saurav.girepunje@gmail.com>

This does not seem to cover the case in dma.c,
which seems to want fixing for the sake of consistency.

Also, I wonder why bools rather than a bitmask was chosen
for this field, it seems rather space intensive in its current form.

> ---
> drivers/net/wireless/broadcom/b43/main.c | 6 +++---
> 1 file changed, 3 insertions(+), 3 deletions(-)
>
> diff --git a/drivers/net/wireless/broadcom/b43/main.c b/drivers/net/wireless/broadcom/b43/main.c
> index b85603e91c7a..39da1a4c30ac 100644
> --- a/drivers/net/wireless/broadcom/b43/main.c
> +++ b/drivers/net/wireless/broadcom/b43/main.c
> @@ -3600,7 +3600,7 @@ static void b43_tx_work(struct work_struct *work)
> else
> err = b43_dma_tx(dev, skb);
> if (err == -ENOSPC) {
> - wl->tx_queue_stopped[queue_num] = 1;
> + wl->tx_queue_stopped[queue_num] = true;
> ieee80211_stop_queue(wl->hw, queue_num);
> skb_queue_head(&wl->tx_queue[queue_num], skb);
> break;
> @@ -3611,7 +3611,7 @@ static void b43_tx_work(struct work_struct *work)
> }
>
> if (!err)
> - wl->tx_queue_stopped[queue_num] = 0;
> + wl->tx_queue_stopped[queue_num] = false;
> }
>
> #if B43_DEBUG
> @@ -5603,7 +5603,7 @@ static struct b43_wl *b43_wireless_init(struct b43_bus_dev *dev)
> /* Initialize queues and flags. */
> for (queue_num = 0; queue_num < B43_QOS_QUEUE_NUM; queue_num++) {
> skb_queue_head_init(&wl->tx_queue[queue_num]);
> - wl->tx_queue_stopped[queue_num] = 0;
> + wl->tx_queue_stopped[queue_num] = false;
> }
>
> snprintf(chip_name, ARRAY_SIZE(chip_name),
> --
> 2.20.1
>

\
 
 \ /
  Last update: 2019-10-29 09:25    [W:0.174 / U:0.252 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site