Messages in this thread | | | Date | Tue, 29 Oct 2019 09:10:07 +0100 | From | Greg KH <> | Subject | Re: [PATCH 1/2] Staging: gasket: implement apex_get_status() to check driver status |
| |
On Tue, Oct 29, 2019 at 12:59:25AM +0200, Samuil Ivanov wrote: > >From the TODO: > - apex_get_status() should actually check status > > The function now checkes the status of the driver > > Signed-off-by: Samuil Ivanov <samuil.ivanovbg@gmail.com> > --- > drivers/staging/gasket/apex_driver.c | 3 +++ > 1 file changed, 3 insertions(+) > > diff --git a/drivers/staging/gasket/apex_driver.c b/drivers/staging/gasket/apex_driver.c > index 46199c8ca441..a5dd6f3c367d 100644 > --- a/drivers/staging/gasket/apex_driver.c > +++ b/drivers/staging/gasket/apex_driver.c > @@ -247,6 +247,9 @@ module_param(bypass_top_level, int, 0644); > static int apex_get_status(struct gasket_dev *gasket_dev) > { > /* TODO: Check device status. */ > + if (gasket_dev->status == GASKET_STATUS_DEAD) > + return GASKET_STATUS_DEAD; > +
Have you tested this to verify that this is what is needed here?
thanks,
greg k-h
| |