Messages in this thread | | | From | Matteo Croce <> | Date | Wed, 30 Oct 2019 00:19:52 +0100 | Subject | Re: [PATCH net-next v2 4/4] bonding: balance ICMP echoes in layer3+4 mode |
| |
On Wed, Oct 30, 2019 at 12:14 AM Eric Dumazet <eric.dumazet@gmail.com> wrote: > > > > On 10/29/19 4:03 PM, Matteo Croce wrote: > > > Hi Eric, > > > > this would work for locally generated echoes, but what about forwarded packets? > > The point behind my changeset is to provide consistent results within > > a session by using the same path for request and response, > > but avoid all sessions flowing to the same path. > > This should resemble what happens with TCP and UDP: different > > connections, different port, probably a different path. And by doing > > this in the flow dissector, other applications could benefit it. > > In principle it is fine, but I was not sure of overall impact of your change > on performance for 99.9% of packets that are not ICMP :) >
Good point. I didn't measure it (I will) but all the code additions are under some if (proto == ICMP) or similar. My guess is that performance shouldn't change for non ICMP traffic, but I'm curious to test it.
-- Matteo Croce per aspera ad upstream
| |