Messages in this thread | | | Date | Mon, 28 Oct 2019 12:01:13 -0700 (PDT) | Subject | Re: [PATCH V3 0/3] Add OP-TEE based bnxt f/w manager | From | David Miller <> |
| |
From: David Miller <davem@davemloft.net> Date: Mon, 28 Oct 2019 11:49:15 -0700 (PDT)
> From: Sheetal Tigadoli <sheetal.tigadoli@broadcom.com> > Date: Thu, 24 Oct 2019 11:02:38 +0530 > >> This patch series adds support for TEE based BNXT firmware >> management module and the driver changes to invoke OP-TEE >> APIs to fastboot firmware and to collect crash dump. >> >> changes from v2: >> - address review comments from Jakub > > Series applied to net-next. > > Please properly annotate your Subject lines in the future to indicate > the exact GIT tree your patches are targetting, ala "[PATCH net-next ...]"
Actually, reverted, this doesn't even compile:
drivers/firmware/broadcom/tee_bnxt_fw.c: In function ‘prepare_args’: drivers/firmware/broadcom/tee_bnxt_fw.c:14:24: error: ‘SZ_4M’ undeclared (first use in this function) #define MAX_SHM_MEM_SZ SZ_4M ^~~~~ drivers/firmware/broadcom/tee_bnxt_fw.c:81:28: note: in expansion of macro ‘MAX_SHM_MEM_SZ’ param[0].u.memref.size = MAX_SHM_MEM_SZ; ^~~~~~~~~~~~~~ drivers/firmware/broadcom/tee_bnxt_fw.c:14:24: note: each undeclared identifier is reported only once for each function it appears in #define MAX_SHM_MEM_SZ SZ_4M ^~~~~ drivers/firmware/broadcom/tee_bnxt_fw.c:81:28: note: in expansion of macro ‘MAX_SHM_MEM_SZ’ param[0].u.memref.size = MAX_SHM_MEM_SZ; ^~~~~~~~~~~~~~ drivers/firmware/broadcom/tee_bnxt_fw.c: In function ‘tee_bnxt_fw_probe’: drivers/firmware/broadcom/tee_bnxt_fw.c:14:24: error: ‘SZ_4M’ undeclared (first use in this function) #define MAX_SHM_MEM_SZ SZ_4M ^~~~~ drivers/firmware/broadcom/tee_bnxt_fw.c:214:44: note: in expansion of macro ‘MAX_SHM_MEM_SZ’ fw_shm_pool = tee_shm_alloc(pvt_data.ctx, MAX_SHM_MEM_SZ, ^~~~~~~~~~~~~~
| |