Messages in this thread | | | Date | Mon, 28 Oct 2019 09:36:04 +0100 (CET) | From | Julia Lawall <> | Subject | Re: [PATCH] staging: octeon: Remove unneeded variable |
| |
On Mon, 28 Oct 2019, Dan Carpenter wrote:
> On Sat, Oct 26, 2019 at 07:24:53PM -0300, Cristiane Naves wrote: > > Remove unneeded variable used to store return value. Issue found by > > coccicheck. > > > > Signed-off-by: Cristiane Naves <cristianenavescardoso09@gmail.com> > > --- > > drivers/staging/octeon/octeon-stubs.h | 4 +--- > > 1 file changed, 1 insertion(+), 3 deletions(-) > > > > diff --git a/drivers/staging/octeon/octeon-stubs.h b/drivers/staging/octeon/octeon-stubs.h > > index b07f5e2..d53bd801 100644 > > --- a/drivers/staging/octeon/octeon-stubs.h > > +++ b/drivers/staging/octeon/octeon-stubs.h > > @@ -1387,9 +1387,7 @@ static inline cvmx_pko_status_t cvmx_pko_send_packet_finish(uint64_t port, > > uint64_t queue, union cvmx_pko_command_word0 pko_command, > > union cvmx_buf_ptr packet, cvmx_pko_lock_t use_locking) > > { > > - cvmx_pko_status_t ret = 0; > > - > > - return ret; > > + return 0; > > What is the point of this function anyway?
Given that it is in octeon-stubs.h, it seems that the point is to get the code to compile when COMPILE_TEST is set. There is a real definition in arch/mips/include/asm/octeon/cvmx-pko.h
julia
| |