lkml.org 
[lkml]   [2019]   [Oct]   [27]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    Patch in this message
    /
    From
    Subject[PATCH 4.19 83/93] pinctrl: armada-37xx: swap polarity on LED group
    Date
    From: Patrick Williams <alpawi@amazon.com>

    commit b835d6953009dc350d61402a854b5a7178d8c615 upstream.

    The configuration registers for the LED group have inverted
    polarity, which puts the GPIO into open-drain state when used in
    GPIO mode. Switch to '0' for GPIO and '1' for LED modes.

    Fixes: 87466ccd9401 ("pinctrl: armada-37xx: Add pin controller support for Armada 37xx")
    Signed-off-by: Patrick Williams <alpawi@amazon.com>
    Cc: <stable@vger.kernel.org>
    Link: https://lore.kernel.org/r/20191001155154.99710-1-alpawi@amazon.com
    Signed-off-by: Linus Walleij <linus.walleij@linaro.org>
    Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>

    ---
    drivers/pinctrl/mvebu/pinctrl-armada-37xx.c | 8 ++++----
    1 file changed, 4 insertions(+), 4 deletions(-)

    --- a/drivers/pinctrl/mvebu/pinctrl-armada-37xx.c
    +++ b/drivers/pinctrl/mvebu/pinctrl-armada-37xx.c
    @@ -183,10 +183,10 @@ static struct armada_37xx_pin_group arma
    PIN_GRP_EXTRA("uart2", 9, 2, BIT(1) | BIT(13) | BIT(14) | BIT(19),
    BIT(1) | BIT(13) | BIT(14), BIT(1) | BIT(19),
    18, 2, "gpio", "uart"),
    - PIN_GRP_GPIO("led0_od", 11, 1, BIT(20), "led"),
    - PIN_GRP_GPIO("led1_od", 12, 1, BIT(21), "led"),
    - PIN_GRP_GPIO("led2_od", 13, 1, BIT(22), "led"),
    - PIN_GRP_GPIO("led3_od", 14, 1, BIT(23), "led"),
    + PIN_GRP_GPIO_2("led0_od", 11, 1, BIT(20), BIT(20), 0, "led"),
    + PIN_GRP_GPIO_2("led1_od", 12, 1, BIT(21), BIT(21), 0, "led"),
    + PIN_GRP_GPIO_2("led2_od", 13, 1, BIT(22), BIT(22), 0, "led"),
    + PIN_GRP_GPIO_2("led3_od", 14, 1, BIT(23), BIT(23), 0, "led"),

    };


    \
     
     \ /
      Last update: 2019-10-27 22:17    [W:4.057 / U:0.132 seconds]
    ©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site