lkml.org 
[lkml]   [2019]   [Oct]   [27]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    Patch in this message
    /
    From
    Subject[PATCH 4.9 43/49] btrfs: block-group: Fix a memory leak due to missing btrfs_put_block_group()
    Date
    From: Qu Wenruo <wqu@suse.com>

    commit 4b654acdae850f48b8250b9a578a4eaa518c7a6f upstream.

    In btrfs_read_block_groups(), if we have an invalid block group which
    has mixed type (DATA|METADATA) while the fs doesn't have MIXED_GROUPS
    feature, we error out without freeing the block group cache.

    This patch will add the missing btrfs_put_block_group() to prevent
    memory leak.

    Note for stable backports: the file to patch in versions <= 5.3 is
    fs/btrfs/extent-tree.c

    Fixes: 49303381f19a ("Btrfs: bail out if block group has different mixed flag")
    CC: stable@vger.kernel.org # 4.9+
    Reviewed-by: Anand Jain <anand.jain@oracle.com>
    Reviewed-by: Johannes Thumshirn <jthumshirn@suse.de>
    Signed-off-by: Qu Wenruo <wqu@suse.com>
    Reviewed-by: David Sterba <dsterba@suse.com>
    Signed-off-by: David Sterba <dsterba@suse.com>
    Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>

    ---
    fs/btrfs/extent-tree.c | 1 +
    1 file changed, 1 insertion(+)

    --- a/fs/btrfs/extent-tree.c
    +++ b/fs/btrfs/extent-tree.c
    @@ -10325,6 +10325,7 @@ int btrfs_read_block_groups(struct btrfs
    btrfs_err(info,
    "bg %llu is a mixed block group but filesystem hasn't enabled mixed block groups",
    cache->key.objectid);
    + btrfs_put_block_group(cache);
    ret = -EINVAL;
    goto error;
    }

    \
     
     \ /
      Last update: 2019-10-27 22:06    [W:4.089 / U:0.084 seconds]
    ©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site