lkml.org 
[lkml]   [2019]   [Oct]   [26]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
Patch in this message
/
From
SubjectRE: [EXT] [PATCH] net: fec: remove redundant assignment to pointer bdp
Date
From: Colin King <colin.king@canonical.com> Sent: Saturday, October 26, 2019 1:23 AM
> The pointer bdp is being assigned with a value that is never read, so the
> assignment is redundant and hence can be removed.
>
> Addresses-Coverity: ("Unused value")
> Signed-off-by: Colin Ian King <colin.king@canonical.com>
Thanks.

Acked-by: Fugang Duan <fugang.duan@nxp.com>
> ---
> drivers/net/ethernet/freescale/fec_main.c | 1 -
> 1 file changed, 1 deletion(-)
>
> diff --git a/drivers/net/ethernet/freescale/fec_main.c
> b/drivers/net/ethernet/freescale/fec_main.c
> index d4d4c72adf49..608196bdd892 100644
> --- a/drivers/net/ethernet/freescale/fec_main.c
> +++ b/drivers/net/ethernet/freescale/fec_main.c
> @@ -2706,7 +2706,6 @@ static void fec_enet_free_buffers(struct
> net_device *ndev)
>
> for (q = 0; q < fep->num_tx_queues; q++) {
> txq = fep->tx_queue[q];
> - bdp = txq->bd.base;
> for (i = 0; i < txq->bd.ring_size; i++) {
> kfree(txq->tx_bounce[i]);
> txq->tx_bounce[i] = NULL;
> --
> 2.20.1

\
 
 \ /
  Last update: 2019-10-26 06:55    [W:0.065 / U:0.092 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site