Messages in this thread | | | Date | Fri, 25 Oct 2019 13:14:15 +0300 | From | Dan Carpenter <> | Subject | Re: [PATCH 04/15] staging: exfat: Clean up return codes - FFS_PERMISSIONERR |
| |
On Thu, Oct 24, 2019 at 12:27:47PM -0400, Valdis Klētnieks wrote: > On Thu, 24 Oct 2019 09:23:33 -0700, Joe Perches said: > > On Thu, 2019-10-24 at 11:53 -0400, Valdis Kletnieks wrote: > > > > if (err) { > > > - if (err == FFS_PERMISSIONERR) > > > + if (err == -EPERM) > > > err = -EPERM; > > > else if (err == FFS_INVALIDPATH) > > > err = -EINVAL; > > > > These test and assign to same value blocks look kinda silly. > > One patch, one thing. Those are getting cleaned up in a subsequent patch.:)
I was just giving an impromptu lecture on this last week.... The one thing per patch means we cleanup the fallout that results from the change. So if you rename a function then you have re-indent the parameters etc. If you remove a cast from (type)(foo + bar) then remove all the extra parentheses and so on.
(I don't have strong feelings about this patch, but I have just been trying to explain the one thing rule recently).
regards, dan carpenter
| |