Messages in this thread | | | Subject | Re: [PATCH v2] coccicheck: support $COCCI being defined as a directory | From | Markus Elfring <> | Date | Thu, 24 Oct 2019 09:55:34 +0200 |
| |
> Second the commit log could be more concise as:
I like your desire for choosing a more appropriate commit message.
> Allow defining COCCI as a directory that contains .cocci files.
I would prefer to concentrate the patch subject on other information.
> In general, at least in simple cases, it is not necessary to mention the > name of the file you are modifying in the comit log, because one can see > that just below from looking at the diffstat and the patch.
This view can be reasonable. - How does it fit to the usual requirement for the specification of a “subsystem” (or “prefix”) according to the canonical patch format? https://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git/tree/Documentation/process/submitting-patches.rst?id=13b86bc4cd648eae69fdcf3d04b2750c76350053#n656
Regards, Markus
| |