Messages in this thread | | | Subject | Re: [PATCH v9 1/8] powerpc: detect the secure boot mode of the system | From | Lakshmi Ramasubramanian <> | Date | Thu, 24 Oct 2019 10:26:47 -0700 |
| |
On 10/23/2019 8:47 PM, Nayna Jain wrote: > This patch defines a function to detect the secure boot state of a > PowerNV system.
> +bool is_ppc_secureboot_enabled(void) > +{ > + struct device_node *node; > + bool enabled = false; > + > + node = of_find_compatible_node(NULL, NULL, "ibm,secvar-v1"); > + if (!of_device_is_available(node)) { > + pr_err("Cannot find secure variable node in device tree; failing to secure state\n"); > + goto out;
Related to "goto out;" above:
Would of_find_compatible_node return NULL if the given node is not found?
If of_device_is_available returns false (say, because node is NULL or it does not find the specified node) would it be correct to call of_node_put?
> + > +out: > + of_node_put(node);
-lakshmi
| |