Messages in this thread | | | Date | Thu, 24 Oct 2019 12:47:16 -0400 | From | Vivien Didelot <> | Subject | Re: [PATCH][next] net: dsa: fix dereference on ds->dev before null check error |
| |
On Thu, 24 Oct 2019 11:32:18 +0100, Colin King <colin.king@canonical.com> wrote: > From: Colin Ian King <colin.king@canonical.com> > > Currently ds->dev is dereferenced on the assignments of pdata and > np before ds->dev is null checked, hence there is a potential null > pointer dereference on ds->dev. Fix this by assigning pdata and > np after the ds->dev null pointer sanity check. > > Addresses-Coverity: ("Dereference before null check") > Fixes: 7e99e3470172 ("net: dsa: remove dsa_switch_alloc helper") > Signed-off-by: Colin Ian King <colin.king@canonical.com>
Reviewed-by: Vivien Didelot <vivien.didelot@gmail.com>
| |