Messages in this thread | | | From | Linus Walleij <> | Date | Thu, 24 Oct 2019 14:06:45 +0200 | Subject | Re: [PATCH v2] pinctrl: sh-pfc: Do not use platform_get_irq() to count interrupts |
| |
On Wed, Oct 16, 2019 at 4:26 PM Geert Uytterhoeven <geert+renesas@glider.be> wrote:
> As platform_get_irq() now prints an error when the interrupt does not > exist, counting interrupts by looping until failure causes the printing > of scary messages like: > > sh-pfc e6060000.pin-controller: IRQ index 0 not found > > Fix this by using the platform_irq_count() helper instead. > > Fixes: 7723f4c5ecdb8d83 ("driver core: platform: Add an error message to platform_get_irq*()") > Signed-off-by: Geert Uytterhoeven <geert+renesas@glider.be> > Reviewed-by: Yoshihiro Shimoda <yoshihiro.shimoda.uh@renesas.com> > Reviewed-by: Stephen Boyd <swboyd@chromium.org> > Reviewed-by: Niklas Söderlund <niklas.soderlund+renesas@ragnatech.se> > Tested-by: Yoshihiro Shimoda <yoshihiro.shimoda.uh@renesas.com> > --- > v2: > - Add Reviewed-by, Tested-by. > > Linus: Can you please take this one, as it is a fix for v5.4? Thx!
I'm not sure the little error message counts as a regression, certainly users can live with it.
Can't you just put it in your queue for the next kernel?
Yours, Linus Walleij
| |