Messages in this thread | | | Subject | Re: [PATCH] powerpc/fadump: Remove duplicate message. | From | Hari Bathini <> | Date | Thu, 24 Oct 2019 16:08:08 +0530 |
| |
Michal, thanks for looking into this.
On 23/10/19 11:26 PM, Michal Suchanek wrote: > There is duplicate message about lack of support by firmware in > fadump_reserve_mem and setup_fadump. Due to different capitalization it > is clear that the one in setup_fadump is shown on boot. Remove the > duplicate that is not shown.
Actually, the message in fadump_reserve_mem() is logged. fadump_reserve_mem() executes first and sets fw_dump.fadump_enabled to `0`, if fadump is not supported. So, the other message in setup_fadump() doesn't get logged anymore with recent changes. The right thing to do would be to remove similar message in setup_fadump() instead.
- Hari
| |