lkml.org 
[lkml]   [2019]   [Oct]   [24]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
From
SubjectRe: [PATCH v2 2/8] cdrom: factor out common open_for_* code
On Wed, Oct 23, 2019 at 07:19:58PM -0700, Christoph Hellwig wrote:
> > static
> > -int open_for_data(struct cdrom_device_info *cdi)
> > +int open_for_common(struct cdrom_device_info *cdi, tracktype *tracks)
>
> Please fix the coding style. static never should be on a line of its
> own..

That's fine.

>
> > } else {
> > cd_dbg(CD_OPEN, "bummer. this drive can't close the tray.\n");
> > - ret=-ENOMEDIUM;
> > - goto clean_up_and_return;
> > + return -ENOMEDIUM;
>
> Can you revert the polarity of the if opening the block before and
> return early for the -ENOMEDIUM case to save on leven of indentation?

Then I will get complaints I do unrelated changes and it's hard to
review. The code gets removed later anyway.

Thanks

Michal

\
 
 \ /
  Last update: 2019-10-24 10:51    [W:0.065 / U:0.360 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site