Messages in this thread | | | From | (Eric W. Biederman) | Date | Thu, 24 Oct 2019 22:39:59 -0500 | Subject | Re: [PATCH 1/2 v5] x86/kdump: always reserve the low 1MiB when the crashkernel option is specified |
| |
lijiang <lijiang@redhat.com> writes:
> * Returns the length of the argument (regardless of if it was > * truncated to fit in the buffer), or -1 on not found. > */ > static int > __cmdline_find_option(const char *cmdline, int max_cmdline_size, > const char *option, char *buffer, int bufsize) > > > According to the above code comment, it should be better like this: > > + if (cmdline_find_option(boot_command_line, "crashkernel", > + NULL, 0) > 0) { > > After i test, i will post again. >
This seems reasonable as we are dealing with x86 only code.
It wound be nice if someone could generalize cmdline_find_option to be arch independent so that crash_core.c:parse_crashkernel could use it. I don't think for this patchset, but it looks like an overdue cleanup.
We run the risk with parse_crashkernel using strstr and this using another algorithm of having different kernel command line parsers giving different results and disagreeing if "crashkernel=" is present or not on the kernel command line.
Eric
| |